[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Carsten

[bugs:#1706] SubString.emptySubString value changes

Status: open
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Thu Aug 06, 2015 12:09 PM UTC
Owner: nobody
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

RBRi-2
  • status: open --> accepted
  • assigned_to: RBRi

[bugs:#1706] SubString.emptySubString value changes

Status: accepted
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Thu Aug 06, 2015 12:09 PM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

RBRi-2
In reply to this post by Carsten

Hi Carsten,

many thanks for finding this. No idea why RBRi did not at a unit test for the fixst fix of the problem. And also no idea whe RBRi has removed his own fix. Maybe he is a bit too old for this kind of things.

Your patch is in SVN. Do you need a new snapshot build?

RBRi


[bugs:#1706] SubString.emptySubString value changes

Status: accepted
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Thu Aug 06, 2015 05:57 PM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

RBRi-2
In reply to this post by Carsten
  • assigned_to: RBRi --> Ahmed Ashour
  • Comment:

Hi Ahmed,

can you pls have a look at core-js. There are still two places where the singleton is used. I suggest to drop the singleton.


[bugs:#1706] SubString.emptySubString value changes

Status: accepted
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Thu Aug 06, 2015 08:13 PM UTC
Owner: Ahmed Ashour
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Carsten
In reply to this post by Carsten

No need for a new snapshot we already built one ourselves.


[bugs:#1706] SubString.emptySubString value changes

Status: accepted
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Thu Aug 06, 2015 08:14 PM UTC
Owner: Ahmed Ashour
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Ahmed Ashour-3
In reply to this post by Carsten
  • status: accepted --> closed
  • assigned_to: Ahmed Ashour --> RBRi
  • Comment:

The test passes in core-js, test case added there.


[bugs:#1706] SubString.emptySubString value changes

Status: closed
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Fri Aug 07, 2015 09:51 AM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

RBRi-2
In reply to this post by Carsten

Carstens test was already fixed by the htmlunit update. But i fear that we have the same problem with core-js in different situations because we use the singleton there also.


[bugs:#1706] SubString.emptySubString value changes

Status: closed
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Mon Aug 24, 2015 11:07 AM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Ahmed Ashour-3
In reply to this post by Carsten

Should we remove SubString.emptySubString completely?


[bugs:#1706] SubString.emptySubString value changes

Status: closed
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Mon Aug 24, 2015 12:59 PM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

RBRi-2
In reply to this post by Carsten

I think yes because a mutable singleton is a time bomb from my point of view....


[bugs:#1706] SubString.emptySubString value changes

Status: closed
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Mon Aug 24, 2015 01:19 PM UTC
Owner: RBRi
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Ahmed Ashour-3
In reply to this post by Carsten
  • status: closed --> accepted
  • assigned_to: RBRi --> Ahmed Ashour

[bugs:#1706] SubString.emptySubString value changes

Status: accepted
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Mon Aug 24, 2015 03:12 PM UTC
Owner: Ahmed Ashour
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------

_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1706 SubString.emptySubString value changes

Ahmed Ashour-3
In reply to this post by Carsten
  • status: accepted --> closed
  • Comment:

SubString.emptySubString() is removed.


[bugs:#1706] SubString.emptySubString value changes

Status: closed
Group: 2.18
Created: Thu Aug 06, 2015 12:09 PM UTC by Carsten
Last Updated: Tue Aug 25, 2015 12:58 PM UTC
Owner: Ahmed Ashour
Attachments:

The following JavaScript causes the variables of SubString.emptySubString to be changed.

'alpha'.replace(/alpha/, '');
/beta/.test('abc beta def'));

replace() calls HtmlUnitRegExpProxy.setProperties() which sets leftContext and rightContext to SubString.emptySubString.
test() calls NativeRegExp.executeRegExp() which changes the variables of SubString.emptySubString as leftContext and rightContext are pointing to it.

See http://sourceforge.net/p/htmlunit/code/6009/ for the fix and http://sourceforge.net/p/htmlunit/code/9849/ which reintroduced the problem. The attached patch reverts 9849 and also removes FixedSubString as it should not be needed anymore (see http://sourceforge.net/p/htmlunit/code/9402/).


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Loading...