[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

Anton-2

[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: open
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Wed May 17, 2017 01:39 PM UTC
Owner: nobody
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

Ahmed Ashour-3

Thanks for your efforts.

However:
Some tests fail with real Chrome/IE: check WebDriverTestCase javadoc about how to run against them.
Even if a test is not supported by real browsers, we need to have matching expectations, whether HtmlUnit follow or not can be marked with @NotYetImplemented
Please run 'mvn checkstyle:checkstyle' before submitting.
Please add the test cases to existing HtmlForm2Test
* You can add your name as an author

Awaiting an updated patch.


[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: open
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Wed May 17, 2017 01:39 PM UTC
Owner: nobody
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2

Hi,
Thanks for a feedback and sorry for long response.

Seems that IE does not support new attributes for input with type='image'. So those tests are failed in real browser. I've added additional browser version validation in implemetation and marked tests as @NotYetImplemented(IE)

Please find updated patch version attached.

Attachments:


[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: open
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Tue May 30, 2017 06:39 AM UTC
Owner: nobody
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2

Hi Anton,

have added your code with some minor modifications. Feel free to review and comment my changes.
Many thanks.


[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: open
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Mon Jul 10, 2017 01:07 PM UTC
Owner: nobody
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2
  • status: open --> pending
  • assigned_to: RBRi

[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: pending
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Wed Jul 12, 2017 06:44 PM UTC
Owner: RBRi
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2

I have a couple comments:
1) for buttonWithFormAction() test behaviour of the real browser(IE) is correct. At least visually I see that content from third url appears after click on button. So browser process 'formaction' attribute value, but in the same getMockWebConnection() returns incorrect number of requests 1 instead of 2 and incorrect url for last request.
2) for formMultipartEncodingTypeTest() threre is no need in setting of contentType. This fix was in my patch but not present in repo.

Everything else looks ok.


[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: pending
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Wed Jul 12, 2017 06:44 PM UTC
Owner: RBRi
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2

Ok, fixed, thanks again.


[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: pending
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Thu Jul 13, 2017 08:29 AM UTC
Owner: RBRi
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[HtmlUnit] [htmlunit:bugs] #1884 HtmlUnit does not support new html5 button's attributes

HtmlUnit - Dev mailing list
In reply to this post by Anton-2
  • status: pending --> closed

[bugs:#1884] HtmlUnit does not support new html5 button's attributes

Status: closed
Group: 2.26
Created: Wed May 17, 2017 01:39 PM UTC by Anton
Last Updated: Thu Jul 13, 2017 04:40 PM UTC
Owner: RBRi
Attachments:

Currently HtmlUnit does not support the following html 5 attributes:
- formaction
- formmethod
- formtarget
- formenctype

If those attributes are specified, they override the appropriate attribute of the button's form owner.

NOTE: applicable only if button has type = 'submit' or input has type='submit', type='image'

Specs:
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formaction
https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#attr-fs-formmethod

btw: I have spotted that currently html form encoding type is not correcly supported so 3 tests are disabled. I will create another ticket for this problem.

Please find the patch in attachment


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Loading...