[HtmlUnit] [htmlunit:bugs] #1906 [PATCH] Added missing final for variable with anonymous class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[HtmlUnit] [htmlunit:bugs] #1906 [PATCH] Added missing final for variable with anonymous class

HtmlUnit - Dev mailing list

[bugs:#1906] [PATCH] Added missing final for variable with anonymous class

Status: open
Group: Latest SVN
Created: Sat Jul 29, 2017 01:37 AM UTC by Richard
Last Updated: Sat Jul 29, 2017 01:37 AM UTC
Owner: nobody
Attachments:

This patch is being created because of violations found in CheckStyle's regression of HtmlUnit during implementation of a bug fix.
PR: https://github.com/checkstyle/checkstyle/pull/4736
Issue: https://github.com/checkstyle/checkstyle/issues/4727

A bug was found in FinalLocalVariable where variables assigned anonymous classes were incorrectly being skipped for detection of this check. The change produced new violations in HtmlUnit as seen below:

[INFO] --- maven-checkstyle-plugin:2.17:check (default-cli) @ htmlunit ---
[INFO] Starting audit...
[ERROR] /pipeline/source/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/Promise.java:209:25: Variable 'thenAction' should be declared final. [FinalLocalVariable]
Audit done.

You can either accept this patch and not have an issue when you upgrade CS with this fix in the future,
or make your own change/fix later when you do upgrade CS.
Please let us know which way you intend to go.

Feel free to ask any questions.
Thanks.


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
Reply | Threaded
Open this post in threaded view
|

[HtmlUnit] [htmlunit:bugs] #1906 [PATCH] Added missing final for variable with anonymous class

HtmlUnit - Dev mailing list
  • status: open --> closed
  • assigned_to: RBRi
  • Comment:

applied, hope that hepls


[bugs:#1906] [PATCH] Added missing final for variable with anonymous class

Status: closed
Group: Latest SVN
Created: Sat Jul 29, 2017 01:37 AM UTC by Richard
Last Updated: Sat Jul 29, 2017 01:37 AM UTC
Owner: RBRi
Attachments:

This patch is being created because of violations found in CheckStyle's regression of HtmlUnit during implementation of a bug fix.
PR: https://github.com/checkstyle/checkstyle/pull/4736
Issue: https://github.com/checkstyle/checkstyle/issues/4727

A bug was found in FinalLocalVariable where variables assigned anonymous classes were incorrectly being skipped for detection of this check. The change produced new violations in HtmlUnit as seen below:

[INFO] --- maven-checkstyle-plugin:2.17:check (default-cli) @ htmlunit ---
[INFO] Starting audit...
[ERROR] /pipeline/source/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/Promise.java:209:25: Variable 'thenAction' should be declared final. [FinalLocalVariable]
Audit done.

You can either accept this patch and not have an issue when you upgrade CS with this fix in the future,
or make your own change/fix later when you do upgrade CS.
Please let us know which way you intend to go.

Feel free to ask any questions.
Thanks.


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop