[HtmlUnit] [htmlunit:bugs] #247 [Patch] Update HtmlSerializer to make it subclass-friendly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[HtmlUnit] [htmlunit:bugs] #247 [Patch] Update HtmlSerializer to make it subclass-friendly

HtmlUnit - Dev mailing list

Woops - that description didn't turn out well at all, and no way to edit it I guess. Trying again here:


I'm suggesting updating some of the method access modifiers to allow for easier subclassing.
Changes:
1) class is public
2) append methods changed to protected
3) added 3 new append helper methods to keep the do methods private

As an alternative to this limited update, I'm happy to make some (strictly optional) modification to the main Serializer, by adding public methods to override the default behavior. For example:
- Add special handler for HtmlAnchor to include the target URL in the output
- Possibly an alternate handler for HtmlTable (not sure yet)

That said, it seemed starting with this subclass compatible Serializer might be the best first step.


[feature-requests:#247] [Patch] Update HtmlSerializer to make it subclass-friendly

Status: open
Group: Latest SVN
Created: Sun Jul 30, 2017 10:06 PM UTC by Rob Kodey
Last Updated: Sun Jul 30, 2017 10:06 PM UTC
Owner: nobody
Attachments:

I'm suggesting updating some of the method access modifiers to allow for easier subclassing.
Changes:
class is public
append methods changed to protected
* added 3 new append helper methods to keep the do methods private

As an alternative to this limited update, I'm happy to make some (strictly optional) modification to the main Serializer, by adding public methods to override the default behavior. For example:
Add special handler for HtmlAnchor to include the target URL in the output
Possibly an alternate handler for HtmlTable (not sure yet)

That said, it seemed starting with this subclass compatible Serializer might be the best first step.


Sent from sourceforge.net because [hidden email] is subscribed to https://sourceforge.net/p/htmlunit/feature-requests/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/htmlunit/admin/feature-requests/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
HtmlUnit-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop